only link against geos C API on non-windows platforms #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megies
added a commit
to obspy/obspy
that referenced
this pull request
Mar 10, 2014
|
Can't see the harm - although I do believe there was a reason I put that in there in the first place. Could you add a Changelog entry? |
|
I really hope I am not breaking anything by this change, for me on Debian Linux it is working at least. But I think for many users it might be a huge gain to be able to just 'pip install' basemap.. |
jswhit
pushed a commit
that referenced
this pull request
Mar 11, 2014
only link against geos C API on non-windows platforms
|
That was a quick merge.. I wanted to propose to add some more tiny bits of information to the GEOS failure message.. I'll open another PR for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently trying to build basemap on Debian Linux using the system wide global GEOS installation fails (installed via aptitude, see https://packages.debian.org/search?keywords=libgeos&searchon=names&suite=stable§ion=all).
This is due to basemap trying to link against the C++ library and looking for a file
/usr/lib/libgeos.sowhile GEOS only provides/usr/lib/libgeos-3.3.3.so. I reported this circumstance to the Debian package maintainer and he replied that it is bad practice to link against the C++ library (see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=741242). Following his reply I removed'geos'from the library list and basemap builds OK and also the normal plotting seems to work fine.For Debian Linux this PR makes basemap install like a charm simply using
pip install basemap(with the respective options to allow files not directly hosted on pypi), removing the need to download the source code and manually compiling the GEOS library included in the source.I am not sure if this creates problems in other parts of basemap, though...?